Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Jul 6, 2018

Make sure you have checked all steps below.

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: setup.py only change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@codecov-io
Copy link

Codecov Report

Merging #3581 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3581      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.02%     
==========================================
  Files         204      204              
  Lines       15492    15492              
==========================================
- Hits        11903    11901       -2     
- Misses       3589     3591       +2
Impacted Files Coverage Δ
airflow/jobs.py 82.74% <0%> (-0.27%) ⬇️
airflow/models.py 88.72% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dd6d8...d851ec7. Read the comment docs.

@asfgit asfgit merged commit d851ec7 into apache:master Jul 6, 2018
@ashb ashb deleted the AIRFLOW-2708-unittest2-devel branch October 12, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants