Raise AirflowOptionalProviderfeature exception for AVP command #36824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command will fail on Airflow 2.6.0 when someone tries to import it, but since it is only really useful in 2.8.0, we should raise the AirflowOptionalProvider execption in case the configuration loader package is missing in Airflow.
boring-cyborg
bot
added
area:providers
provider:amazon
jedcunningham
approved these changes
Jan 16, 2024
Taragolis
approved these changes
Jan 16, 2024
Member
Author
|
Some more details on why it did not fail in the original PR here: #36799 (comment) and fix is coming. Hey @jedcunningham - welcome back :D |
vincbeck
approved these changes
Jan 16, 2024
Member
Author
|
Just random spellcheck failure. Merging. BTW - fix to avoid false positives in PRs in similar cases is here #36825 |
potiuk
deleted the
make-avp-command-raise-optional-provider-feature-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will fail on Airflow 2.6.0 when someone tries to import it, but since it is only really useful in 2.8.0, we should raise the AirflowOptionalProvider execption in case the configuration loader package is missing in Airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.