Remove optimization to install wheel packages for affected providers #36825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
Taragolis,
amoghrajesh,
jedcunningham,
o-nikolas,
pankajkoti and
vincbeck
and removed request for
ashb and
kaxil
vincbeck
approved these changes
Jan 16, 2024
When building wheel providers took a lot of time (12 minutes) there was an optimisation implemented to only build the affected providers and in this case we could not run verification, because having only subset of providers would generate errors during imports. However, changes to make our package bulds reproducible with flit apache#35693 also improve building time for provider packages (all of them are built under 1 minute) and .whl installation had always been rather quick - so we can remove the optimisation now, because side effect of it that in some cases (like apache#36799) it caused the backwards compatibility check succeed - and subsequently continue failing in main canary build.
potiuk
force-pushed
the
install-and-verify-all-providers-always
branch
from
bbd532d to
0b6bb11
Compare
potiuk
changed the title
eladkal
approved these changes
Jan 16, 2024
o-nikolas
approved these changes
Jan 16, 2024
potiuk
added a commit
that referenced
this pull request
Feb 7, 2024
…36825) When building wheel providers took a lot of time (12 minutes) there was an optimisation implemented to only build the affected providers and in this case we could not run verification, because having only subset of providers would generate errors during imports. However, changes to make our package bulds reproducible with flit #35693 also improve building time for provider packages (all of them are built under 1 minute) and .whl installation had always been rather quick - so we can remove the optimisation now, because side effect of it that in some cases (like #36799) it caused the backwards compatibility check succeed - and subsequently continue failing in main canary build. (cherry picked from commit 7086192)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
…36825) When building wheel providers took a lot of time (12 minutes) there was an optimisation implemented to only build the affected providers and in this case we could not run verification, because having only subset of providers would generate errors during imports. However, changes to make our package bulds reproducible with flit #35693 also improve building time for provider packages (all of them are built under 1 minute) and .whl installation had always been rather quick - so we can remove the optimisation now, because side effect of it that in some cases (like #36799) it caused the backwards compatibility check succeed - and subsequently continue failing in main canary build. (cherry picked from commit 7086192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building wheel providers took a lot of time (12 minutes) there was an optimisation implemented to only build the affected providers and in this case we could not run verification, because having only subset of providers would generate errors during imports.
However, changes to make our package bulds reproducible with flit #35693 also improve building time for provider packages (all of them are built under 1 minute) and .whl installation had always been rather quick - so we can remove the optimisation now, because side effect of it that in some cases (like #36799) it caused the backwards compatibility check succeed - and subsequently continue failing in main canary build.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.