Change weight priority type from Integer to Float #38160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
XD-DENG,
ashb,
kaxil,
potiuk and
uranusjr
as code owners
Taragolis
commented
Mar 14, 2024
Contributor
Author
There was a problem hiding this comment.
In case of overflow int32 (MySQL/Postgres) and presumably int64 in SQLite it will raise an error
Example of Postgres error
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
cursor.execute(statement, parameters)
sqlalchemy.exc.DataError: (psycopg2.errors.NumericValueOutOfRange) integer out of range
[SQL: ALTER TABLE task_instance ALTER COLUMN priority_weight TYPE INTEGER ]
(Background on this error at: https://sqlalche.me/e/14/9h9h)
Member
There was a problem hiding this comment.
I don't think we can prevent that easily - and I'd say it's an edge case of an edge-case
Contributor
Author
There was a problem hiding this comment.
Check on backend before save it into the DB 🤣
potiuk
reviewed
Mar 14, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
That indeed looks much simpler :)
Taragolis
added
the
full tests needed
Taragolis
force-pushed
the
change-prioriry-weight-type
branch
from
851d677 to
da97cfb
Compare
Contributor
Author
I have an opposite opinion about it |
uranusjr
approved these changes
Mar 14, 2024
Contributor
Author
|
Closed it should be implemented in top of the #38222 |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change task_instance.priority_weight type from int to float
Alternatives:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.