Ensure priority weight is capped at 32-bit integer to prevent roll-over #43611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Besides some adjustments because of rework of classes in regards of TeskSDK I think this can also be back-ported to Ariflow 2.10 line to prevent errors in roll-over. Therefore tagging as 2.10.4 milestone... but backport would most likely a re-write of this PR. |
Member
|
should we have a newsfragment (just in case) just explaining what happened? |
potiuk
approved these changes
Nov 12, 2024
eladkal
approved these changes
Nov 12, 2024
jscheffl
force-pushed
the
bugfix/out-of-range-priority-weight
branch
from
c18bfe7 to
e9649e6
Compare
pierrejeambrun
approved these changes
Nov 13, 2024
ashb
reviewed
Nov 13, 2024
jscheffl
force-pushed
the
bugfix/out-of-range-priority-weight
branch
from
1b229bf to
2e3bfd5
Compare
jscheffl
added a commit
to jscheffl/airflow
that referenced
this pull request
Nov 14, 2024
…er (apache#43611) * Ensure priority weight is capped at 32-bit integer to prevent roll-over * Add newsfragment * Move range check post type check * Review feedback - consolidate to single implementation for now (cherry picked from commit ab529d1)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #42410 via not converting the priority_weight to float but ensure no roll-over in int is happening - by capping INT values to database limits.
There are several attempts to fix this problem: