Update existing significant newsfragments with the later introduced template format #45678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
vincbeck
reviewed
Jan 15, 2025
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
I reviewed all my newsfragment and they look good. Here is the list:
- newsfragments/41434.significant.rst
- newsfragments/42042.significant.rst
- newsfragments/42280.significant.rst
- newsfragments/43096.significant.rst
- newsfragments/aip-79.significant.rst
I added a comment to add a new type of change. Let me know what you think.
kaxil
reviewed
Jan 15, 2025
kaxil
approved these changes
Jan 15, 2025
Member
|
#protm |
gopidesupavan
approved these changes
Jan 15, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Thanks wei, looks awesome , i have added my comment.
Lee-W
force-pushed
the
update-newsfragments
branch
from
b8e1806 to
2204b7b
Compare
vincbeck
reviewed
Jan 16, 2025
vincbeck
approved these changes
Jan 16, 2025
Member
|
The list moved to the top. |
Member
|
A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it. |
Member
Super 😍 |
Member
|
reviewed mine and marked them in the list |
Member
|
@Lee-W -> If you want - you can move the list up from the comment I made to the description of the PR - to keep it at the top. |
jscheffl
reviewed
Jan 16, 2025
jscheffl
reviewed
Jan 16, 2025
jscheffl
reviewed
Jan 16, 2025
jscheffl
reviewed
Jan 16, 2025
jscheffl
reviewed
Jan 16, 2025
Member
Author
yep, it's super helpful! just updated it |
Lee-W
force-pushed
the
update-newsfragments
branch
from
4e7c465 to
38fedbb
Compare
Contributor
|
Thanks @Lee-W. I have reviewed my changes newsfragments/44533.significant.rst. LGTM! |
vatsrahul1001
approved these changes
Jan 17, 2025
Member
Author
|
I'll keep it open for around 1 week so that everyone can take a look |
Contributor
|
I'd be happy for an explanation about what each "type of change" covers. In my case, I removed a a deprecated |
Lee-W
force-pushed
the
update-newsfragments
branch
from
38fedbb to
bb35d8f
Compare
Lee-W
force-pushed
the
update-newsfragments
branch
4 times, most recently
from
03cf1f0 to
a2386db
Compare
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Lee-W
force-pushed
the
update-newsfragments
branch
from
a2386db to
92b0e42
Compare
Member
Author
|
I think we already have enough checks for this one. Merge it. Thanks for everyone's help! |
utkarsharma2
added
the
changelog:skip
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
…emplate format (apache#45678) * docs(newsfragments): add empty entities to significant newsfragments * docs(newsfragments): update existing siginificant newsfragments with template format * docs(newsfragments): fix typo in 41391, 41533 * docs(newsfragments): add type "Code interface change" * docs(newsfragments): aip-79: make it dependency change * docs(newsfragmenst): update 42042 change type Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * docs(newsfragmenst): update 40029 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41758 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 43612 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41808 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41774 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragments): add description to each of the change type * docs(newsfragments): fix plural typo * docs(newsfragments): replace DAG as Dag * style(newsfragments): add type of change to significant * docs(newsfragments): fix type of changes typo * docs(newsfragments): unify ruff rules format --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…emplate format (apache#45678) * docs(newsfragments): add empty entities to significant newsfragments * docs(newsfragments): update existing siginificant newsfragments with template format * docs(newsfragments): fix typo in 41391, 41533 * docs(newsfragments): add type "Code interface change" * docs(newsfragments): aip-79: make it dependency change * docs(newsfragmenst): update 42042 change type Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * docs(newsfragmenst): update 40029 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41758 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 43612 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41808 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41774 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragments): add description to each of the change type * docs(newsfragments): fix plural typo * docs(newsfragments): replace DAG as Dag * style(newsfragments): add type of change to significant * docs(newsfragments): fix type of changes typo * docs(newsfragments): unify ruff rules format --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…emplate format (apache#45678) * docs(newsfragments): add empty entities to significant newsfragments * docs(newsfragments): update existing siginificant newsfragments with template format * docs(newsfragments): fix typo in 41391, 41533 * docs(newsfragments): add type "Code interface change" * docs(newsfragments): aip-79: make it dependency change * docs(newsfragmenst): update 42042 change type Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * docs(newsfragmenst): update 40029 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41758 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 43612 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41808 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41774 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragments): add description to each of the change type * docs(newsfragments): fix plural typo * docs(newsfragments): replace DAG as Dag * style(newsfragments): add type of change to significant * docs(newsfragments): fix type of changes typo * docs(newsfragments): unify ruff rules format --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…emplate format (apache#45678) * docs(newsfragments): add empty entities to significant newsfragments * docs(newsfragments): update existing siginificant newsfragments with template format * docs(newsfragments): fix typo in 41391, 41533 * docs(newsfragments): add type "Code interface change" * docs(newsfragments): aip-79: make it dependency change * docs(newsfragmenst): update 42042 change type Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * docs(newsfragmenst): update 40029 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41758 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 43612 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41808 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41774 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragments): add description to each of the change type * docs(newsfragments): fix plural typo * docs(newsfragments): replace DAG as Dag * style(newsfragments): add type of change to significant * docs(newsfragments): fix type of changes typo * docs(newsfragments): unify ruff rules format --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Since #44378, we have implemented a newsfragments template to track the breaking changes we have made. However, this template was introduced after many of our earlier breaking changes, which means that most of the existing news fragments do not conform to this format. By updating the existing entries to match the template, we will be able to create a script that summarizes the breaking changes made in Airflow 3.0.
What
Update existing significant newsfragments with the type of changes and migration rules we added in #41641
Closes: #45673
contrib#41366 @jedcunninghamImportErrorfromairflow.models#41367 @jedcunninghamExternalTaskSensorLink#41391 @kaxilTaskMixinclass #41394 @kaxilairflow.executors&airflow.utils#41395 @kaxil--treeflag fromairflow tasks listcommand #41964 @jedcunninghamis_activeuser property to FAB auth manager #42042 @vincbeckAUTH_ROLE_PUBLICin FAB auth manager #42280 @vincbeckdefaultas auth backend #43096 @vincbecktask_failtable #43490 @kaxilairflow/configuration.py#43530 @kaxilairflow.utils.dates#43533 @kaxildbgroup #44706 @jedcunninghamconffrom Task Context #44820 @kaxil^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.