Remove pluggable TaskRunners concept #43551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
added
the
area:task-execution-interface-aip72
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:providers
area:Scheduler
jedcunningham
approved these changes
Oct 31, 2024
ashb
commented
Oct 31, 2024
Member
Author
There was a problem hiding this comment.
@kaxil Let's keep this file up to date as we change more things.
mobuchowski
approved these changes
Oct 31, 2024
ashb
force-pushed
the
remove-pluggable-task-runner-and-cgroup-runner
branch
from
760b498 to
629c8eb
Compare
ashb
commented
Oct 31, 2024
As part of the changes in AIP-72 to have "activities" (i.e. TaskExecuteActivity) and the need to shortly move the StandardTaskRunner into the TaskSDK, and before doing that I want to simplify the strucutre. To that end, the CGroupTaskRunner is being removed. While it (likely/probably) still works, it's use is very uncommon as it does not work within Docker or Kubernetes deployment (as it is not currently possible to nest cgroups inside a container in practice). In this PR I have removed the config option and task_runner loader concept, deleted the CGroupRunner and merged Base and Starndard TaskRunner classes.
ashb
force-pushed
the
remove-pluggable-task-runner-and-cgroup-runner
branch
from
629c8eb to
cc95d05
Compare
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
As part of the changes in AIP-72 to have "activities" (i.e. TaskExecuteActivity) and the need to shortly move the StandardTaskRunner into the TaskSDK, and before doing that I want to simplify the strucutre. To that end, the CGroupTaskRunner is being removed. While it (likely/probably) still works, it's use is very uncommon as it does not work within Docker or Kubernetes deployment (as it is not currently possible to nest cgroups inside a container in practice). In this PR I have removed the config option and task_runner loader concept, deleted the CGroupTaskRunner and merged Base and Starndard TaskRunner classes.
ashb
added a commit
that referenced
this pull request
Apr 11, 2025
The cgroups extra was in place for the CgroupTaskRunner, but that was removed in #43551 -- so this extra is for installing something that Airflow doesn't use anymore. Bye bye!
potiuk
pushed a commit
that referenced
this pull request
Apr 11, 2025
The cgroups extra was in place for the CgroupTaskRunner, but that was removed in #43551 -- so this extra is for installing something that Airflow doesn't use anymore. Bye bye!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes in AIP-72 to have "activities" (i.e. TaskExecuteActivity) and the need to shortly move the StandardTaskRunner into the TaskSDK, and before doing that I want to simplify the strucutre.
To that end, the CGroupTaskRunner is being removed. While it (likely/probably) still works, it's use is very uncommon as it does not work within Docker or Kubernetes deployment (as it is not currently possible to nest cgroups inside a container in practice).
In this PR I have removed the config option and task_runner loader concept, deleted the CGroupRunner and merged Base and Starndard TaskRunner classes.
I have also started keeping an "umberalla" newsfragment where we can track all AIP-72 related changes (of which there will be a lot)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.