Metrics basic deprecated validators removed in favor of pattern matching #41975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
added
area:metrics
airflow3.0:candidate
ferruzzi
requested changes
Sep 3, 2024
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
I am so happy to see these deprecation PRs actually removing stuff!
Left an easy change request/suggestion, otherwise LGTM.
Those unit tests were somewhat convoluted, nice work sorting through them.
ferruzzi
approved these changes
Sep 4, 2024
Contributor
Author
potiuk
approved these changes
Sep 11, 2024
Member
|
Needs to resolve conflict now. |
Contributor
Author
Done. |
Contributor
Author
|
@eladkal |
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…ing (apache#41975) * metrics basic deprecated validators removed * metrics basic deprecated validators removed * news fragment added
2 tasks
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics basic deprecated validators (AllowListValidator and BlockListValidator) removed in favor of pattern matching