-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Rename Dataset database tables as Asset #42023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9e7bbc to
9f9e3d2
Compare
9f9e3d2 to
cf5dd9f
Compare
377166f to
a84053a
Compare
a84053a to
e004c95
Compare
e2ea6dc to
7a13d31
Compare
4889fb8 to
17459a6
Compare
127f09b to
bbc3f1c
Compare
8adbead to
d2a7481
Compare
Member
Author
|
I just address the comments from TP. The last CI failure was due to WTforms issue being fixed in pallets-eco/wtforms#862 (same as #43205 (comment)) Will merge this one |
2 tasks
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* feat(models/asset): rename index idx_dataset_alias_dataset_event_alias_id as idx_asset_alias_asset_event_alias_id
* feat(models/asset): rename index idx_dataset_alias_dataset_event_event_id as idx_asset_alias_asset_event_event_id
* feat(models/asset): rename table dataset_alias_dataset_event as asset_alias_asset_event
* feat(models): rename dataset_alias as asset_alias
* rename table "dataset_alias" as "asset_alias"
* rename table "dataset_alias_dataset" as "asset_alias_dataset"
* rename index "idx_dataset_alias_dataset_alias_id" as "idx_asset_alias_asset_alias_id"
* rename index "idx_dataset_alias_dataset_alias_dataset_id" as "idx_asset_alias_asset_dataset_id"
* rename fk constraint "ds_dsa_alias_id" as "a_aa_alias_id""
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename table "dag_schedule_dataset_alias_reference" as "dag_schedule_asset_alias_reference"
* rename column "dataset_alias" as "asset_alias"
* rename fk constraint "dsdar_dataset_alias_fkey" as "dsaar_asset_alias_fkey"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename index "idx_dag_schedule_dataset_alias_reference_dag_id" as "idx_dag_schedule_asset_alias_reference_dag_id"
* in table "asset_alias_asset_event"
* change fk alias_id reference from "dataset_alias.id" to "asset_alias.id"
* in fk constraint "dss_de_alias_id"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* feat(models/asset): rename table "dag_schedule_dataset_reference" as "dag_schedule_asset_reference"
* rename fk constraint "dsdr_dataset_fkey" as "dsar_dataset_fkey"
* rename fk constraint "dsdr_dag_id_fkey" as "dsar_dag_id_fkey"
* rename index "idx_dag_schedule_dataset_reference_dag_id" as "idx_dag_schedule_asset_reference_dag_id"
* feat(models): rename table "task_outlet_dataset_references" as "task_outlet_asset_references"
* rename fk constraint "todr_dataset_fkey" as "todr_asset_fkey"
* rename index "idx_task_outlet_dataset_reference_dag_id" as "todr_dataset_fkey"
* feat(models/asset): rename table "dagrun_dataset_event" as "dagrun_asset_event"
* rename index "idx_dagrun_dataset_events_dag_run_id" as "idx_dagrun_asset_events_dag_run_id"
* rename index "idx_dagrun_dataset_events_event_id" as "idx_dagrun_asset_events_event_id"
* feat(models/dag): rename column "schedule_dataset_references" as "schedule_asset_references" in table "dag"
* feat(models/asset): rename table "dataset_dag_run_queue" as "asset_dag_run_queue"
* rename index "idx_dataset_dag_run_queue_target_dag_id" as "idx_asset_dag_run_queue_target_dag_id"
* feat(models/dag): rename consumed_dataset_events as consumed_asset_events
* feat(models/asset): rename table "dataset_event" as "asset_event"
* feat(models/asset): rename index idx_dataset_id_timestamp as idx_asset_id_timestamp
* feat(models/asset): rename idx_asset_alias_asset_dataset_id as idx_asset_alias_asset_asset_id
* feat(models/asset): rename dataset as asset in fks
* feat(models/asset): rename asset_alias_dataset as asset_alias_asset
* feat(models/asset): rename index idx_dataset_alias_name_unique as idx_asset_alias_name_unique
* feat(models/asset): rename idx_dataset_name_uri_unique as idx_asset_name_uri_unique
* feat(models/asset): rename dsar_dataset_fkey as dsar_asset_fkey
* feat(models/asset): rename datasetdagrunqueue_pkey as assetdagrunqueue_pkey
* feat(models/asset): rename ddrq_dataset_fkey as ddrq_asset_fkey
* feat(models/asset): rename ddrq fks as adrq fks
* feat(models/asset): rename dsdr keys as dsar keys
* feat(models/asset): rename todr keys as toar keys
* feat(migrations): initial migration files
* feat(migrations): add utility functions _rename_index and _rename_fk_constraint
* feat(migrations): add _rename_pk_constraint utility function
* feat(migrations): update migration files to reflect current model change (except for fk reference table update)
* feat: rename dataset_id as asset_id
* feat(api_connexion): rename dataset_id as asset_id
* feat: rename dataset.uri as asset.uri
* feat: rename dataset_expression as asset_expression
* feat(listeners): rename argument dataset_alias as asset_alias
* feat(utils/types): rename DagRunType.DATASET_TRIGGERED as DagRunType.ASSET_TRIGGERED
* feat: rename dataset_triggered_dag_info as asset_triggered_dag_info
* feat: rename dataset as asset
* feat(models/asset): rename dss_de as aa_ae
* feat(models/asset): rename dsdar as dsaar
* feat(migrations): wrap up the upgrade part (except for fk upgrade)
* feat(migrations): rename migration file
* docs(newsfragment): add place holder newsfragment
* build: generate migration related files
* feat(migrations): wrap up upgrade script
* feat(migrations): wrap up downgrade script
* fix: fix missing frontend change
* fix(migrations): fix fk_constraint rename for association tables
* fix: fix missing dataset related changes due to rebasing
* feat(migrations): reorder migrations
* feat(migrations): fix error for sqlite
* feat(models/asset): remove redundant fk constraint aa_ae_alias_id and aa_ae_event_id
* feat(migrations): remove redundant fk constraint a_aa_asset_id and a_aa_alias_id
* build: generate db migration side files
* feat(migrations): add postgresql support
* feat(migrations): add mysql support for downgrade
* fix: rename reference_table as referent_table
* refactor: reorganize 0038 migration
* docs: improve endpoint asset_triggered change description
* docs: add description to endpoint renaming and note it in newsfragments
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* feat(models/asset): rename index idx_dataset_alias_dataset_event_alias_id as idx_asset_alias_asset_event_alias_id
* feat(models/asset): rename index idx_dataset_alias_dataset_event_event_id as idx_asset_alias_asset_event_event_id
* feat(models/asset): rename table dataset_alias_dataset_event as asset_alias_asset_event
* feat(models): rename dataset_alias as asset_alias
* rename table "dataset_alias" as "asset_alias"
* rename table "dataset_alias_dataset" as "asset_alias_dataset"
* rename index "idx_dataset_alias_dataset_alias_id" as "idx_asset_alias_asset_alias_id"
* rename index "idx_dataset_alias_dataset_alias_dataset_id" as "idx_asset_alias_asset_dataset_id"
* rename fk constraint "ds_dsa_alias_id" as "a_aa_alias_id""
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename table "dag_schedule_dataset_alias_reference" as "dag_schedule_asset_alias_reference"
* rename column "dataset_alias" as "asset_alias"
* rename fk constraint "dsdar_dataset_alias_fkey" as "dsaar_asset_alias_fkey"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename index "idx_dag_schedule_dataset_alias_reference_dag_id" as "idx_dag_schedule_asset_alias_reference_dag_id"
* in table "asset_alias_asset_event"
* change fk alias_id reference from "dataset_alias.id" to "asset_alias.id"
* in fk constraint "dss_de_alias_id"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* feat(models/asset): rename table "dag_schedule_dataset_reference" as "dag_schedule_asset_reference"
* rename fk constraint "dsdr_dataset_fkey" as "dsar_dataset_fkey"
* rename fk constraint "dsdr_dag_id_fkey" as "dsar_dag_id_fkey"
* rename index "idx_dag_schedule_dataset_reference_dag_id" as "idx_dag_schedule_asset_reference_dag_id"
* feat(models): rename table "task_outlet_dataset_references" as "task_outlet_asset_references"
* rename fk constraint "todr_dataset_fkey" as "todr_asset_fkey"
* rename index "idx_task_outlet_dataset_reference_dag_id" as "todr_dataset_fkey"
* feat(models/asset): rename table "dagrun_dataset_event" as "dagrun_asset_event"
* rename index "idx_dagrun_dataset_events_dag_run_id" as "idx_dagrun_asset_events_dag_run_id"
* rename index "idx_dagrun_dataset_events_event_id" as "idx_dagrun_asset_events_event_id"
* feat(models/dag): rename column "schedule_dataset_references" as "schedule_asset_references" in table "dag"
* feat(models/asset): rename table "dataset_dag_run_queue" as "asset_dag_run_queue"
* rename index "idx_dataset_dag_run_queue_target_dag_id" as "idx_asset_dag_run_queue_target_dag_id"
* feat(models/dag): rename consumed_dataset_events as consumed_asset_events
* feat(models/asset): rename table "dataset_event" as "asset_event"
* feat(models/asset): rename index idx_dataset_id_timestamp as idx_asset_id_timestamp
* feat(models/asset): rename idx_asset_alias_asset_dataset_id as idx_asset_alias_asset_asset_id
* feat(models/asset): rename dataset as asset in fks
* feat(models/asset): rename asset_alias_dataset as asset_alias_asset
* feat(models/asset): rename index idx_dataset_alias_name_unique as idx_asset_alias_name_unique
* feat(models/asset): rename idx_dataset_name_uri_unique as idx_asset_name_uri_unique
* feat(models/asset): rename dsar_dataset_fkey as dsar_asset_fkey
* feat(models/asset): rename datasetdagrunqueue_pkey as assetdagrunqueue_pkey
* feat(models/asset): rename ddrq_dataset_fkey as ddrq_asset_fkey
* feat(models/asset): rename ddrq fks as adrq fks
* feat(models/asset): rename dsdr keys as dsar keys
* feat(models/asset): rename todr keys as toar keys
* feat(migrations): initial migration files
* feat(migrations): add utility functions _rename_index and _rename_fk_constraint
* feat(migrations): add _rename_pk_constraint utility function
* feat(migrations): update migration files to reflect current model change (except for fk reference table update)
* feat: rename dataset_id as asset_id
* feat(api_connexion): rename dataset_id as asset_id
* feat: rename dataset.uri as asset.uri
* feat: rename dataset_expression as asset_expression
* feat(listeners): rename argument dataset_alias as asset_alias
* feat(utils/types): rename DagRunType.DATASET_TRIGGERED as DagRunType.ASSET_TRIGGERED
* feat: rename dataset_triggered_dag_info as asset_triggered_dag_info
* feat: rename dataset as asset
* feat(models/asset): rename dss_de as aa_ae
* feat(models/asset): rename dsdar as dsaar
* feat(migrations): wrap up the upgrade part (except for fk upgrade)
* feat(migrations): rename migration file
* docs(newsfragment): add place holder newsfragment
* build: generate migration related files
* feat(migrations): wrap up upgrade script
* feat(migrations): wrap up downgrade script
* fix: fix missing frontend change
* fix(migrations): fix fk_constraint rename for association tables
* fix: fix missing dataset related changes due to rebasing
* feat(migrations): reorder migrations
* feat(migrations): fix error for sqlite
* feat(models/asset): remove redundant fk constraint aa_ae_alias_id and aa_ae_event_id
* feat(migrations): remove redundant fk constraint a_aa_asset_id and a_aa_alias_id
* build: generate db migration side files
* feat(migrations): add postgresql support
* feat(migrations): add mysql support for downgrade
* fix: rename reference_table as referent_table
* refactor: reorganize 0038 migration
* docs: improve endpoint asset_triggered change description
* docs: add description to endpoint renaming and note it in newsfragments
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* feat(models/asset): rename index idx_dataset_alias_dataset_event_alias_id as idx_asset_alias_asset_event_alias_id
* feat(models/asset): rename index idx_dataset_alias_dataset_event_event_id as idx_asset_alias_asset_event_event_id
* feat(models/asset): rename table dataset_alias_dataset_event as asset_alias_asset_event
* feat(models): rename dataset_alias as asset_alias
* rename table "dataset_alias" as "asset_alias"
* rename table "dataset_alias_dataset" as "asset_alias_dataset"
* rename index "idx_dataset_alias_dataset_alias_id" as "idx_asset_alias_asset_alias_id"
* rename index "idx_dataset_alias_dataset_alias_dataset_id" as "idx_asset_alias_asset_dataset_id"
* rename fk constraint "ds_dsa_alias_id" as "a_aa_alias_id""
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename table "dag_schedule_dataset_alias_reference" as "dag_schedule_asset_alias_reference"
* rename column "dataset_alias" as "asset_alias"
* rename fk constraint "dsdar_dataset_alias_fkey" as "dsaar_asset_alias_fkey"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* rename index "idx_dag_schedule_dataset_alias_reference_dag_id" as "idx_dag_schedule_asset_alias_reference_dag_id"
* in table "asset_alias_asset_event"
* change fk alias_id reference from "dataset_alias.id" to "asset_alias.id"
* in fk constraint "dss_de_alias_id"
* change reference column from "dataset_alias.id" to "asset_alias.id"
* feat(models/asset): rename table "dag_schedule_dataset_reference" as "dag_schedule_asset_reference"
* rename fk constraint "dsdr_dataset_fkey" as "dsar_dataset_fkey"
* rename fk constraint "dsdr_dag_id_fkey" as "dsar_dag_id_fkey"
* rename index "idx_dag_schedule_dataset_reference_dag_id" as "idx_dag_schedule_asset_reference_dag_id"
* feat(models): rename table "task_outlet_dataset_references" as "task_outlet_asset_references"
* rename fk constraint "todr_dataset_fkey" as "todr_asset_fkey"
* rename index "idx_task_outlet_dataset_reference_dag_id" as "todr_dataset_fkey"
* feat(models/asset): rename table "dagrun_dataset_event" as "dagrun_asset_event"
* rename index "idx_dagrun_dataset_events_dag_run_id" as "idx_dagrun_asset_events_dag_run_id"
* rename index "idx_dagrun_dataset_events_event_id" as "idx_dagrun_asset_events_event_id"
* feat(models/dag): rename column "schedule_dataset_references" as "schedule_asset_references" in table "dag"
* feat(models/asset): rename table "dataset_dag_run_queue" as "asset_dag_run_queue"
* rename index "idx_dataset_dag_run_queue_target_dag_id" as "idx_asset_dag_run_queue_target_dag_id"
* feat(models/dag): rename consumed_dataset_events as consumed_asset_events
* feat(models/asset): rename table "dataset_event" as "asset_event"
* feat(models/asset): rename index idx_dataset_id_timestamp as idx_asset_id_timestamp
* feat(models/asset): rename idx_asset_alias_asset_dataset_id as idx_asset_alias_asset_asset_id
* feat(models/asset): rename dataset as asset in fks
* feat(models/asset): rename asset_alias_dataset as asset_alias_asset
* feat(models/asset): rename index idx_dataset_alias_name_unique as idx_asset_alias_name_unique
* feat(models/asset): rename idx_dataset_name_uri_unique as idx_asset_name_uri_unique
* feat(models/asset): rename dsar_dataset_fkey as dsar_asset_fkey
* feat(models/asset): rename datasetdagrunqueue_pkey as assetdagrunqueue_pkey
* feat(models/asset): rename ddrq_dataset_fkey as ddrq_asset_fkey
* feat(models/asset): rename ddrq fks as adrq fks
* feat(models/asset): rename dsdr keys as dsar keys
* feat(models/asset): rename todr keys as toar keys
* feat(migrations): initial migration files
* feat(migrations): add utility functions _rename_index and _rename_fk_constraint
* feat(migrations): add _rename_pk_constraint utility function
* feat(migrations): update migration files to reflect current model change (except for fk reference table update)
* feat: rename dataset_id as asset_id
* feat(api_connexion): rename dataset_id as asset_id
* feat: rename dataset.uri as asset.uri
* feat: rename dataset_expression as asset_expression
* feat(listeners): rename argument dataset_alias as asset_alias
* feat(utils/types): rename DagRunType.DATASET_TRIGGERED as DagRunType.ASSET_TRIGGERED
* feat: rename dataset_triggered_dag_info as asset_triggered_dag_info
* feat: rename dataset as asset
* feat(models/asset): rename dss_de as aa_ae
* feat(models/asset): rename dsdar as dsaar
* feat(migrations): wrap up the upgrade part (except for fk upgrade)
* feat(migrations): rename migration file
* docs(newsfragment): add place holder newsfragment
* build: generate migration related files
* feat(migrations): wrap up upgrade script
* feat(migrations): wrap up downgrade script
* fix: fix missing frontend change
* fix(migrations): fix fk_constraint rename for association tables
* fix: fix missing dataset related changes due to rebasing
* feat(migrations): reorder migrations
* feat(migrations): fix error for sqlite
* feat(models/asset): remove redundant fk constraint aa_ae_alias_id and aa_ae_event_id
* feat(migrations): remove redundant fk constraint a_aa_asset_id and a_aa_alias_id
* build: generate db migration side files
* feat(migrations): add postgresql support
* feat(migrations): add mysql support for downgrade
* fix: rename reference_table as referent_table
* refactor: reorganize 0038 migration
* docs: improve endpoint asset_triggered change description
* docs: add description to endpoint renaming and note it in newsfragments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AIP-74
Dataset -> Asset
airflow3.0:breaking
Candidates for Airflow 3.0 that contain breaking changes
area:API
Airflow's REST/HTTP API
area:dev-tools
area:lineage
area:Scheduler
including HA (high availability) scheduler
legacy api
Whether legacy API changes should be allowed in PR
legacy ui
Whether legacy UI change should be allowed in PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #42307
Rename table
dataset_alias_datasetasasset_alias_assetdataset_idasdataset_ididx_dataset_alias_dataset_alias_idasidx_asset_alias_asset_alias_ididx_dataset_alias_dataset_alias_dataset_idasidx_asset_alias_asset_asset_iddataset_alias_dataset_alias_id_fkeyasasset_alias_asset_alias_id_fk_keydataset_alias_dataset_dataset_id_fkeyasasset_alias_asset_asset_id_fk_keyRename table
dataset_alias_dataset_eventasasset_alias_asset_eventidx_dataset_alias_dataset_event_alias_idasidx_asset_alias_asset_event_alias_ididx_dataset_alias_dataset_event_alias_idasidx_asset_alias_asset_event_event_iddataset_alias_dataset_event_alias_id_fkeyasasset_alias_asset_event_asset_id_fkeydataset_alias_dataset_event_event_id_fkeyasasset_alias_asset_event_event_id_fk_keyRename table
dataset_aliasasasset_aliasidx_dataset_alias_name_uniqueasidx_asset_alias_name_uniqueRename table
datasetasassetidx_dataset_name_uri_uniqueasidx_asset_name_uri_uniqueRename table
dag_schedule_dataset_alias_referenceasdag_schedule_asset_alias_referenceidx_dag_schedule_dataset_alias_reference_dag_idasidx_dag_schedule_asset_alias_reference_dag_iddsdar_pkeyasasaar_pkeydsdar_dataset_fkeyasdsaar_asset_alias_fkeydsdar_dag_id_fkeyasdsaar_dag_fkeyRename table
dag_schedule_dataset_referenceasdag_schedule_asset_referencedataset_idasdataset_ididx_dag_schedule_dataset_reference_dag_idasidx_dag_schedule_asset_reference_dag_iddsdr_pkeyasdsar_pkeydsdr_dag_id_fkeyasdsar_dag_id_fkeydsdr_dataset_fkeyasdsar_asset_fkeyRename table
task_outlet_dataset_referenceastask_outlet_asset_referencedataset_idasdataset_ididx_task_outlet_dataset_reference_dag_idasidx_task_outlet_asset_reference_dag_idtodr_pkeyastoar_pkeytodr_dag_id_fkeyastoar_dag_id_fkeytodr_dataset_fkeyastoar_asset_fkeyRename table
dataset_dag_run_queueasasset_dag_run_queuedataset_idasdataset_ididx_dataset_dag_run_queue_target_dag_idasidx_asset_dag_run_queue_target_dag_iddatasetdagrunqueue_pkeyasassetdagrunqueue_pkeyddrq_dag_fkeyasadrq_dag_fkeyddrq_dataset_fkeyasadrq_dag_fkeyRename table
dagrun_dataset_eventasdagrun_asset_eventidx_dagrun_dataset_events_dag_run_idasidx_dagrun_asset_events_dag_run_ididx_dagrun_dataset_events_event_idasidx_dagrun_asset_events_event_iddagrun_dataset_event_event_id_fkeyasdagrun_asset_event_dag_run_id_fkeydagrun_dataset_event_dag_run_id_fkeyasdagrun_asset_event_event_id_fkeyRename table
dataset_eventasasset_eventdataset_idasdataset_ididx_dataset_id_timestampasidx_asset_id_timestampRename column
dataset_expressionindagtable asasset_expression^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.