Remove sending of task logs in otel traces inside the Scheduler #43943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was sending task logs from the scheduler has two problems: 1. It blocks the scheduling loop reading remote logs -- a huge performance foot-gun for anyone that turns this feature on 2. Sending task logs in a span seems too large, and way too verbose to provide any use in a span.
boring-cyborg
bot
added
the
area:Scheduler
ashb
changed the title
potiuk
approved these changes
Nov 13, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
This was sending task logs from the scheduler has two problems: 1. It blocks the scheduling loop reading remote logs -- a huge performance foot-gun for anyone that turns this feature on 2. Sending task logs in a span seems too large, and way too verbose to provide any use in a span.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was sending task logs from the scheduler has two problems:
foot-gun for anyone that turns this feature on
any use in a span.
Addresses #43868 (comment)