Change default .airflowignore syntax to glob #42436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
airflow3.0:candidate
uranusjr
force-pushed
the
airflow-ignore-glob
branch
2 times, most recently
from
91540fa to
41d63ec
Compare
This matches the ignore file behavior of many popular tools (e.g. Git, Docker) and is likely what most users expect without reading the documentation. The documentation is also tweaked to emphasize the new default. I also decided to get rid of some regexp examples entirely; I figure most of the users are better off either using glob, or just customize the might_contain_dag_callable hook instead. The regexp syntax parser uses re2, which is quite limiting for security reasons, and does not offer significant advantages over glob for almost all use cases.
uranusjr
force-pushed
the
airflow-ignore-glob
branch
from
41d63ec to
19595fc
Compare
hussein-awala
approved these changes
Sep 27, 2024
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the ignore file behavior of many popular tools (e.g. Git, Docker) and is likely what most users expect without reading the documentation.
The documentation is also tweaked to emphasize the new default. I also decided to get rid of some regexp examples entirely; I figure most of the users are better off either using glob, or just customize the might_contain_dag_callable hook instead. The regexp syntax parser uses re2, which is quite limiting for security reasons, and does not offer significant advantages over glob for almost all use cases.