Pydantic v2 and FastAPI as core dependency #41857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ashb,
bolkedebruin,
jedcunningham,
kaxil and
potiuk
as code owners
potiuk
approved these changes
Aug 29, 2024
pierrejeambrun
changed the title
Member
|
The failing |
Merged
pierrejeambrun
force-pushed
the
pydantic-as-core-dependency
branch
from
0d17367 to
2358a89
Compare
Member
Author
|
Thanks @potiuk for the tips, rebased. |
Member
Author
|
🤔 the db tests are still failing due to the unique constraint on dag run failing. Not sure how this is related to pydantic |
Member
Was just looking at it - when you removed pydantic test, you have not removed all of it - the |
Member
|
potiuk
reviewed
Aug 29, 2024
jedcunningham
approved these changes
Aug 29, 2024
jscheffl
added
the
airflow3.0:breaking
12 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #41798, pydantic v2 will be part of core requirement now. Mostly because fastapi requires pydantic. Even if fastapi can still (for now) work with pydantic v1, airflow 3 will only support pydantic v2.