Handle Example dags case when checking for missing files #41856
Conversation
utkarsharma2
requested review from
ephraimbuddy and
jedcunningham
as code owners
boring-cyborg
bot
added
the
area:Scheduler
|
@ephraimbuddy I tested it with standalone dag processor in breeze env and it's working as expected. |
utkarsharma2
force-pushed
the
DagParseExamples
branch
2 times, most recently
from
a2f11cf to
ecc119e
Compare
Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly. related: apache#41432
utkarsharma2
force-pushed
the
DagParseExamples
branch
from
ecc119e to
f2ec13e
Compare
|
I believe that was the reason for the Open API test failing ? |
Yes. That's my believe too |
|
@potiuk / @ephraimbuddy, which PR were the tests failing for? |
Never mind, got it. |
Main tests: https://github.com/apache/airflow/actions?query=event%3Aschedule and PRs that got "full tests needed" because for example they modified dependencies. The problem was in this case that there is non-obvious connection between DAGs diseappearing and Open API tests failing - what was failing there was the test that tries to retrieve example DAG information via the API. Those Open API tests are skipped unless you modify API. |
Here: https://github.com/apache/airflow/actions/runs/10613181076/job/29416509993. An example DAG could not be found |
|
Also |
|
Yep. That was it - It's fixed here for example - I rebased failing cloudant provider and it's green now https://github.com/apache/airflow/actions/runs/10615673609/job/29424342526 |
|
Yes, I think it's related. |
|
@utkarsharma2 , can you backport this to v2-10-test |
Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly. related: apache#41432 (cherry picked from commit 435e968)
…1874) Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly. related: #41432 (cherry picked from commit 435e968)
…1874) Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly. related: #41432 (cherry picked from commit 435e968)
)" This reverts commit 435e968.
…che#41856) (apache#41874)" This reverts commit 5e962ed.
…che#41856)" (apache#42193) This reverts commit 435e968.
4 participants
Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly.
related: #41432
closes: #41852