Avoid accidentally upgrading airflow in compatibility check #38545
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
canary
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
jscheffl,
pankajastro and
pankajkoti
hussein-awala
approved these changes
Mar 27, 2024
jscheffl
approved these changes
Mar 27, 2024
potiuk
force-pushed
the
fix-broken-compatibility-check
branch
2 times, most recently
from
6acd515 to
c1e39a2
Compare
Member
Author
|
Turned out that the root cause of it was |
When running compatibility check of providers with airflow, we install airflow first (with constraints) and providers as the next step (without constraints). This might - in some cases lead to accidental upgrade of airflow if `pip` decides to do so. By adding airflow package to the list of providers to install, we will keep it from being accidentally upgraded.
potiuk
force-pushed
the
fix-broken-compatibility-check
branch
from
c1e39a2 to
3b5cc36
Compare
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 31, 2024
When running compatibility check of providers with airflow, we install airflow first (with constraints) and providers as the next step (without constraints). This might - in some cases lead to accidental upgrade of airflow if `pip` decides to do so. By adding airflow package to the list of providers to install, we will keep it from being accidentally upgraded. (cherry picked from commit c855f1f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running compatibility check of providers with airflow, we install airflow first (with constraints) and providers as the next step (without constraints). This might - in some cases lead to accidental upgrade of airflow if
pipdecides to do so.By adding airflow package to the list of providers to install, we will keep it from being accidentally upgraded.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.