Skip to content

Avoid accidentally upgrading airflow in compatibility check #38545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Mar 28, 2024
Merged

Avoid accidentally upgrading airflow in compatibility check #38545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions dev/breeze/src/airflow_breeze/global_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,6 @@ def _exclusion(providers: Iterable[str]) -> str:
"airflow-version": "2.6.0",
"remove-providers": _exclusion(["openlineage", "common.io", "cohere", "fab", "qdrant"]),
},
{
"python-version": "3.9",
"airflow-version": "2.6.0",
"remove-providers": _exclusion(["openlineage", "common.io", "fab", "qdrant"]),
},
{
"python-version": "3.8",
"airflow-version": "2.7.1",
Expand Down
6 changes: 6 additions & 0 deletions scripts/in_container/install_airflow_and_providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,12 @@ def install_airflow_and_providers(
for provider_package in installation_spec.provider_packages:
base_install_providers_cmd.append(provider_package)
install_providers_command = base_install_providers_cmd.copy()
# if airflow is also being installed we should add airflow to the base_install_providers_cmd
# to avoid accidentally upgrading airflow to a version that is different than installed in the
# previous step
if installation_spec.airflow_package:
base_install_providers_cmd.append(installation_spec.airflow_package)

if installation_spec.provider_constraints_location:
console.print(
f"[bright_blue]with constraints: {installation_spec.provider_constraints_location}\n"
Expand Down