[AIRFLOW-2966] Catch ApiException in the Kubernetes Executor #3960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This build will fail because the recent release of |
Codecov Report
@@ Coverage Diff @@
## master #3960 +/- ##
===========================================
- Coverage 76.67% 63.65% -13.02%
===========================================
Files 199 199
Lines 16186 20018 +3832
===========================================
+ Hits 12410 12743 +333
- Misses 3776 7275 +3499
Continue to review full report at Codecov.
|
Contributor
Author
|
Travis passes in my environment, but the incubator-airflow build times-out on an unrelated test. Restarting the build may pass, since this seems to be a symptom of a flaky kubernetes test environment. |
Contributor
|
@johnhofman Can you rebase onto master? |
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
Contributor
Author
|
@Fokko I have rebased. Is this failing test something I need to look into? |
Contributor
|
Sorry @johnhofman, I was a bit busy. I've restarted the failing test, let's see if it passes now. The Kubernetes tests can sometimes be a bit flaky. |
Contributor
|
@Fokko tests passed |
Fokko
pushed a commit
to Fokko/incubator-airflow
that referenced
this pull request
Nov 18, 2018
…pache#3960)" This reverts commit 03de9ee.
Contributor
|
@johnhofman I had to revert the commit again. The CI wasn't happy. Please take a look and open a new PR: https://travis-ci.org/apache/incubator-airflow/jobs/456661023 |
tmiller-msft
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Nov 27, 2018
…3960) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
tmiller-msft
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Nov 27, 2018
…pache#3960)" This reverts commit 03de9ee.
elizabethhalper
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Dec 7, 2018
…3960) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
elizabethhalper
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Dec 7, 2018
…pache#3960)" This reverts commit 03de9ee.
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
…3960) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
…pache#3960)" This reverts commit 03de9ee.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…3960) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…pache#3960)" This reverts commit 03de9ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
click 7.0was recently released butflask-appbuilder 1.11.1 has requirement click==6.7. I have pinnedclick==6.7to make the dependencies resolve.Tests
This adds a single test
TestKubernetesExecutor. test_run_next_exceptionthat covers this single scenario. Without the changes this test fails when the ApiException is not caught.This is the first test case for the
KubernetesExecutor, so I needed to add the[kubernetes]section todefault_test.cfgso that theKubernetesExecutorcan be built without exceptions.Jira ticket: https://issues.apache.org/jira/browse/AIRFLOW-2966