[AIRFLOW-2966] Catch ApiException in the Kubernetes Executor #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
+ Coverage 77.7% 77.71% +<.01%
==========================================
Files 199 199
Lines 16317 16317
==========================================
+ Hits 12679 12680 +1
+ Misses 3638 3637 -1
Continue to review full report at Codecov.
|
Fokko
approved these changes
Nov 20, 2018
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @johnhofman, looking good. Thanks for rebasing and fixing the tests.
tmiller-msft
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Nov 27, 2018
…4209) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
elizabethhalper
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Dec 7, 2018
…4209) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
…4209) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
ashb
pushed a commit
that referenced
this pull request
Mar 21, 2019
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
ashb
pushed a commit
that referenced
this pull request
Mar 22, 2019
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…4209) Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches the exception and the task is re-queued inside the Executor instead of killing the scheduler.
click 7.0was recently released butflask-appbuilder 1.11.1 has requirement click==6.7. I have pinnedclick==6.7to make the dependencies resolve.Tests
This adds a single test
TestKubernetesExecutor. test_run_next_exceptionthat covers this single scenario. Without the changes this test fails when the ApiException is not caught.This is the first test case for the
KubernetesExecutor, so I needed to add the[kubernetes]section todefault_test.cfgso that theKubernetesExecutorcan be built without exceptions.Jira ticket: https://issues.apache.org/jira/browse/AIRFLOW-2966