AIP-62: Add HookLineageCollector #40335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
from
7382021 to
1293a07
Compare
uranusjr
reviewed
Jun 20, 2024
mobuchowski
requested changes
Jul 4, 2024
Contributor
mobuchowski
left a comment
mobuchowski
left a comment
There was a problem hiding this comment.
Overall looks good, however, I'd add some more "practical tests" that show how mechanism works.
Would also love to see better documentation, though I think it can just link to something that would be populated later in provider docs in followup PR.
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
from
1293a07 to
4e81003
Compare
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
2 times, most recently
from
ce0994c to
75ec801
Compare
mobuchowski
approved these changes
Jul 8, 2024
Contributor
|
@uranusjr want to take another look? |
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
2 times, most recently
from
585ec21 to
f6af11a
Compare
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
2 times, most recently
from
b651b1a to
6c9e124
Compare
mobuchowski
added
the
AIP-62
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
3 times, most recently
from
0380e68 to
5f6c253
Compare
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
2 times, most recently
from
1f54e98 to
53f6a97
Compare
mobuchowski
reviewed
Jul 15, 2024
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
from
53f6a97 to
adecb55
Compare
should register and hold lineage sent from hooks. Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks. Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
from
adecb55 to
89fed8e
Compare
Add section in experimental lineage docs. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
aip-62/hook-lineage-collector
branch
from
89fed8e to
351d2bc
Compare
ephraimbuddy
added
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Add HookLineageCollector that during task execution should register and hold lineage sent from hooks. Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks. Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> * Remove default `create_dataset` method. Add section in experimental lineage docs. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> --------- Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HookLineageCollector that during task execution should register and hold lineage sent from hooks.
Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks.
Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant.
Closes: #38766
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.