Fix RedshiftCreateClusterOperator to always specify PubliclyAccessible

[vincbeck]

PubliclyAccessible needs to be always specified because the default value (if not provided) is True on Redshift service side

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[ferruzzi]

I might have added a comment to say why it is different from the rest, but I'll approve it. Thanks for fixing this.

[vincbeck]

I might have added a comment to say why it is different from the rest, but I'll approve it. Thanks for fixing this.

If PubliclyAccessible is not provided to the service, it considers it as True. Thus, when passing False to publicly_accessible, with the current code, it does not set it, which is then considered as True for Redshift. Removing the if solves that issue

if self.publicly_accessible:
            params["PubliclyAccessible"] = self.publicly_accessible

[ferruzzi]

I get it, but just looking at the code it is not clear why that one value isn't wrapped in an if like all the others are. No biggie, I over-comment everything :P

[vincbeck]

I get it, but just looking at the code it is not clear why that one value isn't wrapped in an if like all the others are. No biggie, I over-comment everything :P

Oh! Get it :) That's a good point, adding a comment

[ferruzzi]

I can just see someone in the future looking at that operator and deciding to clean it up and not even noticing thta one parameter is handled differently; even worse, now that I think of it, the tests would all still pass if they did unintentionally revert that in an effort to standardize or clean up that cascading mess of if statements....