Skip to content

Fix RedshiftCreateClusterOperator to always specify PubliclyAccessible #40872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 2 commits into from
Jul 18, 2024
Merged

Fix RedshiftCreateClusterOperator to always specify PubliclyAccessible #40872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0860f1b
Fix `RedshiftCreateClusterOperator` to always specify `PubliclyAccess…
vincbeck Jul 18, 2024
46e1c6a
Add comment
vincbeck Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions airflow/providers/amazon/aws/operators/redshift_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,6 @@ def execute(self, context: Context):
params["ClusterVersion"] = self.cluster_version
if self.allow_version_upgrade:
params["AllowVersionUpgrade"] = self.allow_version_upgrade
if self.publicly_accessible:
params["PubliclyAccessible"] = self.publicly_accessible
if self.encrypted:
params["Encrypted"] = self.encrypted
if self.hsm_client_certificate_identifier:
Expand Down Expand Up @@ -287,6 +285,10 @@ def execute(self, context: Context):
if self.default_iam_role_arn:
params["DefaultIamRoleArn"] = self.default_iam_role_arn

# PubliclyAccessible is True by default on Redshift side, hence, we should always set it regardless
# of its value
params["PubliclyAccessible"] = self.publicly_accessible

cluster = redshift_hook.create_cluster(
self.cluster_identifier,
self.node_type,
Expand Down