Fix Kinesis Analytics system test #41489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the default `force=False` the test fails on our CI because the data retention policy is blocking the deletion.
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon
vincbeck
approved these changes
Aug 14, 2024
o-nikolas
approved these changes
Aug 14, 2024
Contributor
Author
|
There are some test failures but they don't appear to be related. |
hussein-awala
approved these changes
Aug 15, 2024
Member
|
As strange as it seems I identified this failing tests as something that was not detected in main build because of pytest 8.* bug pytest-dev/pytest#12605 I fixed it in #41500 and also workarounded the pytest bug in #41499 |
potiuk
approved these changes
Aug 15, 2024
Contributor
Author
|
Strange, nice catch Jarek. Github went down shortly after I saw the failing test here so I was thinking it was just a precursor for that and didn't look too deep yet. |
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
With the default `force=False` the test fails on our CI because the data retention policy is blocking the deletion.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
With the default `force=False` the test fails on our CI because the data retention policy is blocking the deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default
force=Falsethe test fails on our CI because the data retention policy is blocking the deletion.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.