Fix Non-DB test calculation for main builds #41499

potiuk · 2024-08-15T12:15:16Z

Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build.

The issue in Pytest 8.2 (used to work before) is tracked at
pytest-dev/pytest#12605

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in apache#41499

potiuk · 2024-08-15T12:46:58Z

Ok. Now we correctly fail Non-DB tests for spark kubernetes in "main" build - this will be fixed after #41500 is merged.

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in #41499

Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build. The issue in Pytest 8.2 (used to work before) is tracked at pytest-dev/pytest#12605

Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build. The issue in Pytest 8.2 (used to work before) is tracked at pytest-dev/pytest#12605 (cherry picked from commit d489826)

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in apache#41499

Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build. The issue in Pytest 8.2 (used to work before) is tracked at pytest-dev/pytest#12605

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in apache#41499

Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build. The issue in Pytest 8.2 (used to work before) is tracked at pytest-dev/pytest#12605

…41610) * Enable pull requests to be run from v*test branches (#41474) (#41476) Since we switch from direct push of cherry-picking to open PRs against v*test branch, we should enable PRs to run for the target branch. (cherry picked from commit a9363e6) * Prevent provider lowest-dependency tests to run in non-main branch (#41478) (#41481) When running tests in v2-10-test branch, lowest depenency tests are run for providers - because when calculating separate tests, the "skip_provider_tests" has not been used to filter them out. This PR fixes it. (cherry picked from commit 75da507) * Make PROD image building works in non-main PRs (#41480) (#41484) The PROD image building fails currently in non-main because it attempts to build source provider packages rather than use them from PyPi when PR is run against "v-test" branch. This PR fixes it: * PROD images in non-main-targetted build will pull providers from PyPI rather than build them * they use PyPI constraints to install the providers * they use UV - which should speed up building of the images (cherry picked from commit 4d5f1c4) * Add WebEncoder for trigger page rendering to avoid render failure (#41350) (#41485) Co-authored-by: M. Olcay Tercanlı <muhammed_tercanli@epam.com> * Incorrect try number subtraction producing invalid span id for OTEL airflow (issue #41501) (#41502) (#41535) * Fix for issue #39336 * removed unnecessary import (cherry picked from commit dd3c3a7) Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com> * Fix failing pydantic v1 tests (#41534) (#41541) We need to exclude some versions of Pydantic v1 because it conflicts with aws provider. (cherry picked from commit a033c5f) * Fix Non-DB test calculation for main builds (#41499) (#41543) Pytest has a weird behaviour that it will not collect tests from parent folder when subfolder of it is specified after the parent folder. This caused some non-db tests from providers folder have been skipped during main build. The issue in Pytest 8.2 (used to work before) is tracked at pytest-dev/pytest#12605 (cherry picked from commit d489826) * Add changelog for airflow python client 2.10.0 (#41583) (#41584) * Add changelog for airflow python client 2.10.0 * Update client version (cherry picked from commit 317a28e) * Make all test pass in Database Isolation mode (#41567) This adds dedicated "DatabaseIsolation" test to airflow v2-10-test branch.. The DatabaseIsolation test will run all "db-tests" with enabled DB isolation mode and running `internal-api` component - groups of tests marked with "skip-if-database-isolation" will be skipped. * Upgrade build and chart dependencies (#41570) (#41588) (cherry picked from commit c88192c) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Limit watchtower as depenendcy as 3.3.0 breaks moin. (#41612) (cherry picked from commit 1b602d5) * Enable running Pull Requests against v2-10-stable branch (#41624) (cherry picked from commit e306e7f) * Fix tests/models/test_variable.py for database isolation mode (#41414) * Fix tests/models/test_variable.py for database isolation mode * Review feedback (cherry picked from commit 736ebfe) * Make latest botocore tests green (#41626) The latest botocore tests are conflicting with a few requirements and until apache-beam upcoming version is released we need to do some manual exclusions. Those exclusions should make latest botocore test green again. (cherry picked from commit a13ccbb) * Simpler task retrieval for taskinstance test (#41389) The test has been updated for DB isolation but the retrieval of task was not intuitive and it could lead to flaky tests possibly (cherry picked from commit f25adf1) * Skip database isolation case for task mapping taskinstance tests (#41471) Related: #41067 (cherry picked from commit 7718bd7) * Skipping tests for db isolation because similar tests were skipped (#41450) (cherry picked from commit e94b508) --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Brent Bovenzi <brent@astronomer.io> Co-authored-by: M. Olcay Tercanlı <muhammed_tercanli@epam.com> Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

potiuk requested review from ashb and jedcunningham as code owners August 15, 2024 12:15

boring-cyborg bot added the area:dev-tools label Aug 15, 2024

potiuk requested review from eladkal, hussein-awala and vincbeck August 15, 2024 12:15

potiuk added a commit to potiuk/airflow that referenced this pull request Aug 15, 2024

Mark TestSparkKubernetes test as db test

65075df

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in apache#41499

potiuk mentioned this pull request Aug 15, 2024

Mark TestSparkKubernetes test as db test #41500

Merged

potiuk force-pushed the fix-non-db-test-types-calculation branch from 137ebe8 to 6ba8cb1 Compare August 15, 2024 12:25

potiuk mentioned this pull request Aug 15, 2024

testpaths = A A/B doesn't test folder A (used to work in v7.4.4) pytest-dev/pytest#12605

Open

potiuk requested a review from kaxil August 15, 2024 12:43

potiuk mentioned this pull request Aug 15, 2024

Fix Kinesis Analytics system test #41489

Merged

hussein-awala approved these changes Aug 15, 2024

View reviewed changes

vincbeck pushed a commit that referenced this pull request Aug 15, 2024

Mark TestSparkKubernetes test as db test (#41500)

666183f

This test missed the mark and it has not been detected because of a bugggy pytest behaviour pytest-dev/pytest#12605 that we had to workaround in #41499

vincbeck approved these changes Aug 15, 2024

View reviewed changes

potiuk force-pushed the fix-non-db-test-types-calculation branch from 6ba8cb1 to 4b3c953 Compare August 15, 2024 14:06

potiuk merged commit d489826 into apache:main Aug 15, 2024

potiuk deleted the fix-non-db-test-types-calculation branch August 15, 2024 14:50

utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 30, 2024

utkarsharma2 added this to the Airflow 2.10.1 milestone Aug 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Non-DB test calculation for main builds #41499

Fix Non-DB test calculation for main builds #41499

Uh oh!

potiuk commented Aug 15, 2024 •

edited

Loading

Uh oh!

potiuk commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix Non-DB test calculation for main builds #41499

Fix Non-DB test calculation for main builds #41499

Uh oh!

Conversation

potiuk commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potiuk commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

potiuk commented Aug 15, 2024 •

edited

Loading