-
Notifications
You must be signed in to change notification settings - Fork 16.4k
UI API Add views tests #41957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI API Add views tests #41957
Conversation
|
I need to add the CI integration. (i.e extends the API test suite) |
4e8f063 to
1c6454a
Compare
1c6454a to
a6678e6
Compare
|
@bbovenzi @pierrejeambrun @potiuk What will be our strategy for migrating the API endpoints to the new UI API? Are we planning to do a lift and shift or are we planning to change some parts while moving them? I think we can start migrating API endpoints after this PR. Please correct me if I am wrong, we don't need to wait for follow-up work items listed here #41798 (comment). We can test the endpoints locally in parallel with those works. I wanted to align with you before starting work on migrating endpoints to the UI API. |
I think it's a good topic to discuss at the next dev call (this Thursday) |
|
bugraoz93 I would say that the initial idea is to just migrate existing endpoints to the new API (FastAPI), modifying only endpoints if necessary so we can re-wire the old UI on new endpoints and be sure that things are working as expected. Also this will minimize the migration effort and limit code duplication because at this point we can just delete the legacy endpoint. Then we can take airflow 3 opportunity to bring any breaking change that we need for improvements / refactoring etc. I am not sur we are fully ready to start the migration yet. Very close for 'private' endpoints i.e I would say that we can start migrating once:
You can keep following PRs with
I'll write the documentation down, If we are happy with it and agree with the general strategy I can present it to the rest of the community. (This thurday if I manage to do it before then or at the next call) |
Fantastic ! |
|
And even if we have no write-up - we can just intiate the discussion and outline the idea this Thursday |
|
@pierrejeambrun Awesome! Rewiring is a great idea to reduce duplication and minimize effort. I will follow up on PRs. Thanks for the details! |
|
Well there's been follow up on that So the idea will be to follow the same strategy that we have for front-end views. Duplicate, limit contributions on the old RestAPI and make the new UI Rest API rich enough so the old one can then be deleted. Brent already wrote something here #41903 if you want more details. We will suggest that on the airflow 3 community dev call this thursday and see what others think about that. |
|
@bugraoz93 I just started a thread in the dev list too. Trying to get the old UI to use the new rest API will create a lot of work for us that we will just have to delete soon, especially if we want to redesign some endpoints. So I think the best course of action is to have duplicate code for a short time. |
|
@bbovenzi @pierrejeambrun Amazing, thanks both! Yeah, I agree with both of you, if we are going to make changes then it would be hard to keep up. We will benefit from defining these things, at least from a higher level. |
Small PR that adds sample tests for views of the new UI API.