-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Implement SimpleAuthManager
#42004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SimpleAuthManager
#42004
Conversation
ferruzzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not great with front-end yet, but it all appears to be in order. +0 (binding) :P
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but also no UI / View experience enough to make constructive comments - so maybe others (@bbovenzi @pierrejeambrun might comment how this will fit in the future as well).
I like how indeed "simple" it is now. Probably we should figure out the way how you could set (and override) the user/role mappoing. I am not 100% convinced if webserver config is the right way - IMHO having a toml-based structured configuration might be better (but it will be future work as you mentioned).
100% agree with you. I dont like it either but it is more a temporary solution. Whenever we switch the Airflow config to TOML, my intention is to leverage it |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pure-reading the code looks good - as integration in breeze will come later - what is the esiest way to test (locally)? Would like to see it pre.merge on my laptop once :-D
|
RTFM :-D Besides one small nit in the example is working for the legacy UI. |
Yep, waiting for AIP-68 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend code looks good. Just the form could be improved for better error handling (we have a useErrorToast) and use ReactQuery with an onSubmit, instead of the oldschool action interface. But this will get updated when we move to the new UI anyway, so I don't think it's worth spending more time on that.
Implement the simple auth manager intended to be used in Airflow 3. For more information about the simple auth manager, see #41683.
Login form

Login form (dark mode)

Error message when wrong credentials

What is not part of this PR and will be done in follow-up PRs:
This simple auth manager is required for completion of AIP-79.
Other note:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.