Skip to content

Conversation

@dstandish
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 26, 2024
@dstandish dstandish merged commit 73dd6c1 into apache:main Sep 26, 2024
@dstandish dstandish deleted the fix-main-generated-api-ts branch September 26, 2024 13:39
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 26, 2024

I do not understand why the hook was 'skipped' in the original PR. file detection looks correct in the hook configuration.
https://github.com/apache/airflow/actions/runs/10974274062/job/30472669861?pr=42388

And running pre-commit run ts-compile-format-lint-www on the commit diff 663da777f9 works as expected 🤔

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 26, 2024

Also we might want to cherry pick that to v2-10-test

done: PR here #42537

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Sep 27, 2024
pierrejeambrun added a commit that referenced this pull request Sep 27, 2024
(cherry picked from commit 73dd6c1)

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
(cherry picked from commit 73dd6c1)

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
(cherry picked from commit 73dd6c1)

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants