Skip fastapi-cli Indirection and SSL/TLS on Debug
#42443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaXOng
force-pushed
the
main
branch
4 times, most recently
from
a052d0e to
c41e1c9
Compare
pierrejeambrun
requested review from
ephraimbuddy,
jscheffl,
pierrejeambrun and
potiuk
and removed request for
pierrejeambrun and
potiuk
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Member
|
up |
pierrejeambrun
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Member
|
up |
pierrejeambrun
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Member
|
I don't think that's needed anymore. (ssl/tls on debug mode). We can always come back to this if people ask for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on, #42395. Have just added the SSL/TLS flags to the debug control flow.
fastapicli does not have SSL flags, but it is a thin wrapper arounduvicorn.run(https://github.com/fastapi/fastapi-cli/blob/main/src/fastapi_cli/cli.py#L92)Have created the
Appendabletest utility to declare files/filepaths inpytest.mark.parametrizethat are to be relativetmp_path. Lmk if it is a bit weird / not good. Or whether it should be separated out into a different PR.There are some CI failures, not too sure atm if it is because ofAtm, the only failing CI check looks to be resolved as a part of #42500.uvicorn[standard]>=0.15.0or flakiness. Between fa4239a and ba2fec5 same checks did not fail (barring mypy). Other PRs that trigger the same checks seem to sometimes error too (though error message is a bit different).fastapi[standard]>=0.112.2itself requiresuvicorn[standard]>=0.15.0, wondering though whether sinceuvicornis no longer a transitive dependency the tests fail.related: #42359
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.