Fix failing log test handler tests #42762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:celery
provider:cncf-kubernetes
dstandish
approved these changes
Oct 5, 2024
potiuk
force-pushed
the
fix-failing-tests-for-test-log-handler
branch
from
4b6cce3 to
29f0b02
Compare
The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively.
jscheffl
force-pushed
the
fix-failing-tests-for-test-log-handler
branch
from
29f0b02 to
2a8f8d0
Compare
jscheffl
reviewed
Oct 5, 2024
eladkal
approved these changes
Oct 5, 2024
Contributor
Contributor
|
Fixed by #42772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well.
Fixed the tests and move them to K8S / Celery provider respectively.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.