Fix failing tests for test log handler #42769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:celery
provider:cncf-kubernetes
The apache#42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well. Fixed the tests and move them to K8S / Celery provider respectively.
jscheffl
force-pushed
the
fix-failing-tests-for-test-log-handler
branch
from
cb48328 to
4c19081
Compare
jscheffl
commented
Oct 5, 2024
| def teardown_method(self): | ||
| self.clean_up() | ||
|
|
||
| @pytest.mark.skipif(not AIRFLOW_V_2_9_PLUS, reason="The tests should be skipped for Airflow < 2.9") |
Contributor
Author
There was a problem hiding this comment.
@potiuk don't know why this is failing in Airflow 2.8 Compat... do you know? Okay to "just exclude"?
shahar1
approved these changes
Oct 5, 2024
Contributor
Author
|
Fixed by #42772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to push to #42762 branch, therefore attempt to fix in parallel:
The #42751 removed airflow_version from k8s log handler and apparently some tests in tests_utils still use kubernetes provider and k8s test handler. Also it turned out some other tests used Celery Executor as well.
Fixed the tests and move them to K8S / Celery provider respectively.