AIP-84 Migrate Modify Dag Run endpoint to FastAPI #42973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
…AIP-84/modify_dag_run
12 tasks
rawwar
commented
Oct 13, 2024
rawwar
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
approved these changes
Oct 13, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I can not answer the question but otherwise the PR looks good. Would leave the merge to @pierrejeambrun answer
pierrejeambrun
added
the
legacy api
…AIP-84/modify_dag_run
…AIP-84/modify_dag_run
rawwar
commented
Oct 15, 2024
pierrejeambrun
requested changes
Oct 16, 2024
Member
|
You will have to rebase and fix conflicts as we change how |
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
…AIP-84/modify_dag_run
…AIP-84/modify_dag_run
…AIP-84/modify_dag_run
…AIP-84/modify_dag_run
pierrejeambrun
approved these changes
Oct 29, 2024
bbovenzi
reviewed
Oct 29, 2024
2 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* add modify_dag_run * add tests * Update airflow/api_fastapi/views/public/dag_run.py * fix * Update airflow/api_fastapi/routes/public/dag_run.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * Update airflow/api_fastapi/serializers/dag_run.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * use dagbag * replace patch with put * refactor * use put in tests * modify to patch * add update_mask * refactor update to patch --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #42701