Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Oct 16, 2024

In preparation for adding #43015, this PRs re-organizes the api_fastapi. The goal will be to have 2 apps: execution_api (Task Execution API: AIP-72) and the core_api (UI and Public API).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 16, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I like the naming as well.

I think we also need to mirror those changes on the test folder.

In 17_adding_api_endpoints.rst I think we still have a reference to api_fastapi/views.

@kaxil
Copy link
Member Author

kaxil commented Oct 16, 2024

Thanks @pierrejeambrun , I updated docs & tests

Good idea, I like the naming as well.

I think we also need to mirror those changes on the test folder.

In 17_adding_api_endpoints.rst I think we still have a reference to api_fastapi/views.

In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have
2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks

@kaxil kaxil merged commit 39a16c0 into apache:main Oct 16, 2024
@kaxil kaxil deleted the reorg-api branch October 16, 2024 12:37
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Development

Successfully merging this pull request may close these issues.

2 participants