Move TaskInstance heartbeat directly on to TI row, not on Job row #43599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
requested review from
XD-DENG,
bolkedebruin,
hussein-awala,
o-nikolas,
pierrejeambrun and
potiuk
as code owners
boring-cyborg
bot
added
area:CLI
area:db-migrations
jedcunningham
approved these changes
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
dstandish
reviewed
Nov 1, 2024
This is part of the work for AIP-72 epic, but is done as a separate PR for ease of review. This PR byitself doesn't remove the LocalTaskJob row (that will happen in a future PR when the exeuction code is moved over to live in the TaskSDK) but this paves the way for it. The reason we are making this change is: - Having a separate row for tracking TI heartbeat is not really buying us much - With the addition of TaskInstanceHistory we don't need _another_ separate record of when/where TIs were run - It simplifies things (one less join in finding zombies) - Makes zombie tracking eaiser -- it is now just on the TI state, not the combination of TI and Job state.
ashb
force-pushed
the
move-heartbeat-to-ti-table
branch
from
32b90a5 to
6b17040
Compare
ashb
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
jscheffl
approved these changes
Nov 2, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Never noticed this structure and even w/o AIP-72 this seems to be odd. Good that you move it.
ashb
force-pushed
the
move-heartbeat-to-ti-table
branch
from
df23756 to
e180588
Compare
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 4, 2024
Follow-up of apache#43599, specifically https://github.com/apache/airflow/pull/43599/files#r1826351853 from @dstandish.
kaxil
added
the
airflow3.0:breaking
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…ache#43599) This is part of the work for AIP-72 epic, but is done as a separate PR for ease of review. This PR by itself doesn't remove the LocalTaskJob row (that will happen in a future PR when the execution code is moved over to live in the TaskSDK) but this paves the way for it. The reason we are making this change is: - Having a separate row for tracking TI heartbeat is not really buying us much - With the addition of TaskInstanceHistory we don't need _another_ separate record of when/where TIs were run - It simplifies things (one less join in finding zombies) - Makes zombie tracking easier -- it is now just on the TI state, not the combination of TI and Job state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work for AIP-72 epic, but is done as a separate PR for
ease of review.
This PR byitself doesn't remove the LocalTaskJob row (that will happen in a
future PR when the exeuction code is moved over to live in the TaskSDK) but
this paves the way for it. The reason we are making this change is:
record of when/where TIs were run
combination of TI and Job state.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.