Replace subtask references #43665
Closed
Replace subtask references #43665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of apache#43599, specifically https://github.com/apache/airflow/pull/43599/files#r1826351853 from @dstandish.
boring-cyborg
bot
added
area:CLI
area:Scheduler
dstandish
reviewed
Nov 4, 2024
|
|
||
| self.log.info("Running: %s", self._command) | ||
| self.log.info("Subtask %s", self._task_instance.task_id) | ||
| self.log.info("Task %s", self._task_instance.task_id) |
Contributor
There was a problem hiding this comment.
to me this has basically no content. i would move it to the L161 message and just put the key value task_id=%s
wdyt?
Contributor
There was a problem hiding this comment.
like the task id is only useful as an attr to identify a meaningful log event. but it is not in itself a meaningful log event.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #43599, specifically https://github.com/apache/airflow/pull/43599/files#r1826351853 from @dstandish.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.