Delete the Serialized Dag and DagCode before DagVersion migration #43700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for a smooth migration from the old DB to the new one that added versioning; otherwise, the non-nullable columns raise an integrity error. Instead of populating those not nullable columns, this seems to be a better option since the Serialized Dag and DagCode would be regenerated after the migration.
boring-cyborg
bot
added
area:db-migrations
ephraimbuddy
requested review from
ashb,
dstandish,
jedcunningham,
kaxil and
uranusjr
potiuk
approved these changes
Nov 5, 2024
potiuk
added a commit
that referenced
this pull request
Nov 6, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…ache#43700) This is necessary for a smooth migration from the old DB to the new one that added versioning; otherwise, the non-nullable columns raise an integrity error. Instead of populating those not nullable columns, this seems to be a better option since the Serialized Dag and DagCode would be regenerated after the migration.
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Revert "Delete the Serialized Dag and DagCode before DagVersion migration (apache#43700)" This reverts commit 438f71d. * Revert "AIP-65: Add DAG versioning support (apache#42913)" This reverts commit 1116f28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for a smooth migration from the old DB to the new one that added versioning; otherwise, the non-nullable columns raise an integrity error.
Instead of populating those not nullable columns, this seems to be a better option since the Serialized Dag and DagCode would be regenerated after the migration.