Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Nov 6, 2024

Revert "Delete the Serialized Dag and DagCode before DagVersion migration #43700
Revert "AIP-65: Add DAG versioning support #42913


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk added full tests needed We need to run full set of tests for this PR to merge upgrade to newer dependencies If set, upgrade to newer dependencies is forced canary When set on PR running from apache repo - behave as canary run all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Nov 6, 2024
@potiuk
Copy link
Member Author

potiuk commented Nov 6, 2024

Attempting to revert the changes that are likely causing flaky tests on `main' cc: @ephraimbuddy -> let's see if that will help, and if it will, we should revert, and make a closer investigation - with redoing those two reverted changes.

@potiuk potiuk requested a review from bugraoz93 November 6, 2024 09:33
@potiuk
Copy link
Member Author

potiuk commented Nov 6, 2024

Closing in favour of #43731 43731 that seem to fix the cause of the problem.

@potiuk potiuk closed this Nov 6, 2024
@potiuk potiuk reopened this Nov 6, 2024
@potiuk potiuk merged commit b757bd8 into main Nov 6, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Revert "Delete the Serialized Dag and DagCode before DagVersion migration (apache#43700)"

This reverts commit 438f71d.

* Revert "AIP-65: Add DAG versioning support (apache#42913)"

This reverts commit 1116f28.
@potiuk potiuk deleted the attempt-to-revert-dag-versioning branch January 11, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:API Airflow's REST/HTTP API area:CLI area:db-migrations PRs with DB migration area:dev-tools area:providers area:Scheduler including HA (high availability) scheduler area:serialization area:task-sdk area:webserver Webserver related Issues canary When set on PR running from apache repo - behave as canary run full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:fab upgrade to newer dependencies If set, upgrade to newer dependencies is forced

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants