Skip to content

Conversation

@omkar-foss
Copy link
Collaborator

closes: #42874
related: #42370

This migrates the Get Task API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 5, 2024
@omkar-foss omkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 5, 2024
@omkar-foss omkar-foss self-assigned this Nov 5, 2024
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from 619aaa5 to 535b646 Compare November 5, 2024 19:35
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from 53bbc36 to 7cc3eed Compare November 8, 2024 13:37
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch 2 times, most recently from 7467a22 to f0f1850 Compare November 8, 2024 13:50
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 8, 2024

@pierrejeambrun PR rebased and synced with main and all comments resolved, please check it out. Thank you!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Need rebasing and conflicts resolution. Thanks

@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from c78d799 to 9bf4670 Compare November 8, 2024 15:43
@omkar-foss
Copy link
Collaborator Author

Overall looking good. Need rebasing and conflicts resolution. Thanks

Done! Rebased and conflicts resolved ✅

@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from 3ef30fa to f8e9b09 Compare November 8, 2024 16:22
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch 2 times, most recently from bc1d210 to eecc938 Compare November 11, 2024 17:52
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing again. Ready to merge

@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from eecc938 to ee693e7 Compare November 13, 2024 07:53
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-task branch from ec8effc to aaddea5 Compare November 13, 2024 07:57
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 13, 2024

Needs rebasing again. Ready to merge

@pierrejeambrun rebasing done, thank you ✅

@pierrejeambrun pierrejeambrun merged commit 6519657 into apache:main Nov 13, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate public endpoint Get Task to FastAPI, with main resynced

* Re-run static checks

* Remove extra router line
@omkar-foss omkar-foss deleted the aip-84/tasks/get-task branch November 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Get Task to FastAPI

4 participants