Skip to content

Migrate public endpoint Get Tasks to FastAPI #43980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 5 commits into from
Nov 15, 2024
Merged

Migrate public endpoint Get Tasks to FastAPI #43980

pierrejeambrun merged 5 commits into from
Nov 15, 2024

Conversation

@omkar-foss
Copy link
Collaborator

@omkar-foss omkar-foss commented Nov 13, 2024

closes: #42875
related: #42370

This migrates the Get Tasks API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 13, 2024
@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-tasks branch from 2e1d174 to 7bdaa5d Compare November 13, 2024 19:42
@omkar-foss omkar-foss marked this pull request as ready for review November 13, 2024 19:42
@omkar-foss omkar-foss self-assigned this Nov 13, 2024
@omkar-foss omkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 13, 2024
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 13, 2024

@pierrejeambrun This PR also addresses the pending part from #43718 - have used model_validator which worked well to access the task properly, and have also moved the _get_class_ref() function to the tasks data model as it's not very reusable. Cheers.

pierrejeambrun
pierrejeambrun reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Thanks for the refactoring as well, it's cleaner.

One minor suggestion, because of a recent change of convention introduced in a PR merged yesterday.

Ready to merge after that.

@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-tasks branch 3 times, most recently from 60cfdf6 to 245b9c4 Compare November 14, 2024 15:50
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 14, 2024

@pierrejeambrun PR synced with main and all conversations resolved. Thank you! ✅

@omkar-foss omkar-foss force-pushed the aip-84/tasks/get-tasks branch from 245b9c4 to 8b7bc20 Compare November 14, 2024 18:32
@pierrejeambrun pierrejeambrun merged commit f66459b into apache:main Nov 15, 2024
@omkar-foss omkar-foss deleted the aip-84/tasks/get-tasks branch November 15, 2024 18:12
kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024
@omkar-foss
Migrate public endpoint Get Tasks to FastAPI (apache#43980)
6bfc8b7 
* Migrate public endpoint Get Tasks to FastAPI

* Re-run static checks

* Add migration marker

* Remove 401 and 403, which are now added by default

* Re-run static checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@jscheffl jscheffl Awaiting requested review from jscheffl

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees

@omkar-foss omkar-foss

Labels

area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Get Tasks to FastAPI

2 participants

@omkar-foss @pierrejeambrun