Skip to content

AIP-65: Add back DAG versioning support #43735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ephraimbuddy merged 3 commits into from
Nov 7, 2024
Merged

AIP-65: Add back DAG versioning support #43735

ephraimbuddy merged 3 commits into from
Nov 7, 2024

Conversation

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy ephraimbuddy commented Nov 6, 2024

This reverts commit b757bd8.

@ephraimbuddy ephraimbuddy added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Nov 6, 2024
@ephraimbuddy ephraimbuddy reopened this Nov 6, 2024
@ephraimbuddy ephraimbuddy added the legacy api Whether legacy API changes should be allowed in PR label Nov 6, 2024
@ephraimbuddy ephraimbuddy reopened this Nov 6, 2024
@potiuk
Copy link
Member

potiuk commented Nov 6, 2024

Yeah.. Looks like fairly reliably flaky (if we can use such oxymoron :D ).

potiuk
potiuk reviewed Nov 7, 2024
View reviewed changes
potiuk
potiuk approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, though i'd be more happy if this one is rebased (and tests are green) after #43771 that should fix google.auth pickiness about mocks used.

@ephraimbuddy
Copy link
Contributor Author

ephraimbuddy commented Nov 7, 2024

Should be good, though i'd be more happy if this one is rebased (and tests are green) after #43771 that should fix google.auth pickiness about mocks used.

Yeah, rebased, and it was green except for a Kubernetes test and task sdk test that stopped midway. Have rebased again. Let's see how it goes

@ephraimbuddy ephraimbuddy reopened this Nov 7, 2024
@ephraimbuddy ephraimbuddy merged commit cb23472 into apache:main Nov 7, 2024
1 check passed
@ephraimbuddy ephraimbuddy deleted the add-dagversioning branch November 7, 2024 11:01
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@ephraimbuddy @ellisms
AIP-65: Add back DAG versioning support (apache#43735)
bec9f36 
* AIP-65: Add back DAG versioning support

This reverts commit b757bd8.

* Minimize test changes

* Init DagBag where needed instead of using fixture
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

Assignees

No one assigned

Labels

AIP-65: DAG history in UI all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:API Airflow's REST/HTTP API area:CLI area:db-migrations PRs with DB migration area:dev-tools area:providers area:Scheduler including HA (high availability) scheduler area:serialization area:task-sdk area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge kind:documentation legacy api Whether legacy API changes should be allowed in PR provider:fab

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ephraimbuddy @potiuk @jedcunningham