Fix pickyness of google.auth 2.36.0 for mocks #43771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google-auth 2.36.0 is more picky about credentials being mocked. It expects the `universe_domain` attribute to be real string not mock because it passes it as argument of `replace` string method.
boring-cyborg
bot
added
area:providers
provider:google
potiuk
requested review from
Lee-W,
eladkal,
ephraimbuddy,
hussein-awala,
rawwar,
romsharon98,
shahar1 and
utkarsharma2
Lee-W
approved these changes
Nov 7, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Google-auth 2.36.0 is more picky about credentials being mocked. It expects the `universe_domain` attribute to be real string not mock because it passes it as argument of `replace` string method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google-auth 2.36.0 is more picky about credentials being mocked. It expects the
universe_domainattribute to be real string not mock because it passes it as argument ofreplacestring method.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.