AIP-84 Migrating GET ASSETS Legacy API to fastAPI #43783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
pierrejeambrun
added
legacy api
amoghrajesh
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
amoghrajesh
commented
Nov 8, 2024
Contributor
Author
|
Okay seems like the dag_ids filter doesn't work yet. FIxing it |
ephraimbuddy
reviewed
Nov 8, 2024
This was referenced Nov 8, 2024
pierrejeambrun
changed the title
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good overall, thanks.
Need rebasing to solve conflicts, small nitpicks.
Contributor
Author
|
With the latest commits, most of the things should be taken care of. |
Member
|
Thanks, don't hesitate to resolve conversation that you have adressed. I'm out of office until tuesday. (Bank holiday in france) |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* AIP-84: Migrating GET Assets to fastAPI * matching response to legacy * Adding unit tests - part 1 * Update airflow/api_fastapi/common/parameters.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fixing the dag_ids filter * fixing the dag_ids filter * Adding unit tests - part 2 * fixing unit tests & updating parameter type * review comments pierre * fixing last commit * fixing unit tests --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42370
Migrating the connexion API for GET ASSETS to fastAPI.
Testing performed:
Created 2 pairs of DAGS each linking to different assets
API responses using legacy and fastAPI endpoints (one example with all params used)
Legacy API:
Fast API:
Swagger Spec:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.