AIP 84: Migrate GET one ASSET legacy API to fast API #43825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
amoghrajesh
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
amoghrajesh
commented
Nov 8, 2024
Contributor
Author
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@pierrejeambrun a note for you
1 task
kaxil
reviewed
Nov 8, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
A few common comments from the previous PR that this work is based off.
Otherwise looks good, I'll do a final in depth review once the previous PR is merged.
Contributor
Author
|
@pierrejeambrun the PR has been rebased now. Only has the relevant changes |
pierrejeambrun
approved these changes
Nov 13, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good.
One more nit on the tests and we can merge
Contributor
Author
|
Thanks for the review @pierrejeambrun! Handled the review comment for tests. Merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO REVIEWERS
Only last 2 commits are relevant
Depends on #43783
related: #42370
Migrating the connexion API for GET one ASSETS to fastAPI.
Testing performed:
API responses:
Legacy:
FastAPI:
Swagger Spec:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.