fix google datacatalog operator tests #44281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
potiuk
approved these changes
Nov 22, 2024
amoghrajesh
approved these changes
Nov 22, 2024
Member
Author
|
This seems version bump is required. in canary its installing latest version. |
Member
Author
|
merging this one now, failures are not related to this change :) |
kaxil
reviewed
Nov 22, 2024
| } | ||
| TEST_TAG: Tag = Tag(name=TEST_TAG_PATH) | ||
| TEST_TAG_DICT: dict = {"fields": {}, "name": TEST_TAG_PATH, "template": "", "template_display_name": ""} | ||
| TEST_TAG_DICT: dict = { |
Member
There was a problem hiding this comment.
@gopidesupavan I suggest doing similar to https://github.com/apache/airflow/pull/44037/files
Member
Author
There was a problem hiding this comment.
ah i see, got it. i will update that. thank you
22 tasks
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Dec 23, 2024
* fix google datacatalog operator tests * bump google-cloud-datacatalog (cherry picked from commit f6bbc63)
potiuk
pushed a commit
that referenced
this pull request
Dec 24, 2024
* fix google datacatalog operator tests * bump google-cloud-datacatalog (cherry picked from commit f6bbc63)
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* fix google datacatalog operator tests * bump google-cloud-datacatalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP has released new version of google-cloud-datacatalog, it seems added extra attributes.
https://github.com/apache/airflow/actions/runs/11965065908/job/33364323283#step:11:5147
https://cloud.google.com/python/docs/reference/datacatalog/latest/changelog
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.