-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Enforce to forbid extra fields under execution_api #44986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
65215a4 to
0419c2b
Compare
a0ae953 to
ac39ba4
Compare
|
Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a PR opened for doing that in the core_apis. More information here:
#44306
I suggest to consolidate the approach for all of our APIs.
Most likely Bodies / input payloads have forbid_extra=True, but Responses do not. (because this is useful for filtering down a subpart of a model, and this feature is used by some endpoints).
|
@pierrejeambrun Thanks for sharing issue.
I'll review the shared PR and make adjustments based on it! |
ac39ba4 to
76fcae9
Compare
51e685a to
a358b7d
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. A few suggestions, but looking good.
|
One test to remove and we should be good. |
I'm in gym now, go back to fix soon! |
be2e289 to
c22d21a
Compare
|
Re-running failed job |
c22d21a to
5111226
Compare
|
@pierrejeambrun Do i need to modify code? |
|
CI is green, merging, thanks. |
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
closes: #44978
related: #44306
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.