Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

All K8s tests started failing in https://github.com/apache/airflow/actions/runs/13158509534.

When traced down, this is the error:

2025-02-05T14:49:01.975482931Z stdout F [2025-02-05T14:49:01.975+0000] {_trace.py:47} DEBUG - receive_response_body.started request=<Request [b'PATCH']>
2025-02-05T14:49:01.975742808Z stdout F 2025-02-05 14:49:01 [info     ] Process exited                 [supervisor] exit_code=<Negsignal.SIGKILL: -9> pid=155 signal=SIGKILL
2025-02-05T14:49:01.977567917Z stdout F [2025-02-05T14:49:01.976+0000] {local_executor.py:99} ERROR - uhoh
2025-02-05T14:49:01.977577034Z stdout F Traceback (most recent call last):
2025-02-05T14:49:01.977581732Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/executors/local_executor.py", line 95, in _run_worker
2025-02-05T14:49:01.977586171Z stdout F     _execute_work(log, workload)
2025-02-05T14:49:01.977590339Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/executors/local_executor.py", line 116, in _execute_work
2025-02-05T14:49:01.977594466Z stdout F     supervise(
2025-02-05T14:49:01.977598674Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py", line 970, in supervise
2025-02-05T14:49:01.977602662Z stdout F     process = ActivitySubprocess.start(
2025-02-05T14:49:01.977606619Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py", line 602, in start
2025-02-05T14:49:01.977620685Z stdout F     proc._on_child_started(ti=what, dag_rel_path=dag_rel_path, bundle_info=bundle_info)
2025-02-05T14:49:01.977625254Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py", line 611, in _on_child_started
2025-02-05T14:49:01.977629722Z stdout F     ti_context = self.client.task_instances.start(ti.id, self.pid, datetime.now(tz=timezone.utc))
2025-02-05T14:49:01.97763392Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/api/client.py", line 133, in start
2025-02-05T14:49:01.977638399Z stdout F     return TIRunContext.model_validate_json(resp.read())
2025-02-05T14:49:01.977642506Z stdout F   File "/home/airflow/.local/lib/python3.9/site-packages/pydantic/main.py", line 656, in model_validate_json
2025-02-05T14:49:01.977647135Z stdout F     return cls.__pydantic_validator__.validate_json(json_data, strict=strict, context=context)
2025-02-05T14:49:01.977651122Z stdout F pydantic_core._pydantic_core.ValidationError: 1 validation error for TIRunContext
2025-02-05T14:49:01.977655821Z stdout F dag_run.run_after
2025-02-05T14:49:01.977659999Z stdout F   Extra inputs are not permitted [type=extra_forbidden, input_value='2025-02-05T00:00:00Z', input_type=str]
2025-02-05T14:49:01.977664077Z stdout F     For further information visit https://errors.pydantic.dev/2.10/v/extra_forbidden

This makes #45732 the obvious candidate but that was merged a couple days ago, we shouldve seen the failures earlier.

But, #44986 was merged recently which doesn't allow extra fields in any datamodels, due to which the fields added in the previous PR started screaming.

This PR updates the fields in task sdk datamodels.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh added the full tests needed We need to run full set of tests for this PR to merge label Feb 5, 2025
@amoghrajesh amoghrajesh closed this Feb 5, 2025
@amoghrajesh amoghrajesh reopened this Feb 5, 2025
@bugraoz93 bugraoz93 mentioned this pull request Feb 5, 2025
@amoghrajesh
Copy link
Contributor Author

Okay got this one through!!

@amoghrajesh amoghrajesh merged commit e644d02 into apache:main Feb 6, 2025
91 checks passed
@potiuk
Copy link
Member

potiuk commented Feb 6, 2025

NICE! COOL @amoghrajesh !

insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants