Revert "AIP-79 Generate assets for Flask application in FAB provider" #45057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: I#ll have another PR as fix in 5min, maybe that saves a reversion... |
Contributor
Author
|
I propose to close this in favor of #45058 |
Member
|
Yep. |
Contributor
Author
|
Other PR as quick fix failed, so I change my opinion and would propose the reversion route. Then we can re-apply and check fully. |
vincbeck
approved these changes
Dec 18, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#44744)" (apache#45057) This reverts commit ba49469.
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44744
Seems to be the "quickest" way to fix main, will re-open a PR to merge back again with full tests after
FYI @vincbeck
Broken build: https://github.com/apache/airflow/actions/runs/12399970802/job/34616478712