Bugfix CI problems after PR 44744 to compile www assets #45058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
the
full tests needed
potiuk
approved these changes
Dec 18, 2024
Contributor
Author
|
Okay, I thought this is an easy fix... but it seems the pre-commit is also failing on a clean worktree - not an expert but smells like the yarn.lock is missing and needs to be added. But it is not generated so I can not add it. I propose to go rather the reversion route and then make it "right". |
Contributor
Author
|
Attempting another yarn.lock, maybe this fixes it... |
Contributor
Author
|
Okay, giving.up here :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken canary in https://github.com/apache/airflow/actions/runs/12399970802/job/34616478712
as introduced by #44744
as alternative to #45057