Revert "Fix fetch_access_token_for_cluster in EKS hook" #45526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
2 tasks
eladkal
approved these changes
Jan 9, 2025
hussein-awala
approved these changes
Jan 9, 2025
potiuk
approved these changes
Jan 9, 2025
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Revert "Fix the way to get STS endpoint in EKS hook (apache#45520)" This reverts commit 103df61. * Revert "Fix `fetch_access_token_for_cluster` in EKS hook (apache#45469)" This reverts commit dc3111a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #45469 and #45520.
#45469 introduced a bug. All EKS system tests are failing because of that bug. I tried to fix it as part of #45520 but no luck, even though it is working on my laptop. Reverting for now to avoid regressions in the Amazon provider package.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.