Generate partition aware STS endpoints for EKS Hook #45725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now the STS endpoint url used by the EKS hook (during token generation) was hardcoded to be the commercial partition. This change ensures the endpoint urls respect partitions and regions.
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
reviewed
Jan 16, 2025
vincbeck
approved these changes
Jan 16, 2025
vincbeck
reviewed
Jan 16, 2025
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Up until now the STS endpoint url used by the EKS hook (during token generation) was hardcoded to be the commercial partition. This change ensures the endpoint urls respect partitions and regions.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Up until now the STS endpoint url used by the EKS hook (during token generation) was hardcoded to be the commercial partition. This change ensures the endpoint urls respect partitions and regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now the STS endpoint url used by the EKS hook (during token generation) was hardcoded to be the commercial partition. This change ensures the endpoint urls respect partitions and regions.
fixes #45368
Prior work and context:
fetch_access_token_for_clusterin EKS hook #45469 Fix the way to get STS endpoint in EKS hook #45520 Revert "Fix fetch_access_token_for_cluster in EKS hook" #45526^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.