Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 22, 2025

When Task SDK sources change, provider code is impacted as they are using Task SDK - some tests might fail because of changes there.

Example case: #45917


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When Task SDK sources change, provider code is impacted as they
are using Task SDK - some tests might fail because of changes there.

Example case: apache#45917
@potiuk
Copy link
Member Author

potiuk commented Jan 22, 2025

Merging. The failures are unrelated and worked in on in #45917

@potiuk potiuk merged commit 96d1c81 into apache:main Jan 22, 2025
83 of 90 checks passed
@potiuk potiuk deleted the run-provider-tests-when-task-sdk-changes branch January 22, 2025 10:32
@amoghrajesh
Copy link
Contributor

Yeah, looks nice!

dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
When Task SDK sources change, provider code is impacted as they
are using Task SDK - some tests might fail because of changes there.

Example case: apache#45917
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
When Task SDK sources change, provider code is impacted as they
are using Task SDK - some tests might fail because of changes there.

Example case: apache#45917
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
When Task SDK sources change, provider code is impacted as they
are using Task SDK - some tests might fail because of changes there.

Example case: apache#45917
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
When Task SDK sources change, provider code is impacted as they
are using Task SDK - some tests might fail because of changes there.

Example case: apache#45917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants