Skip to content

When Task SDK sources change, we also run provider tests #45921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jan 22, 2025
Merged

When Task SDK sources change, we also run provider tests #45921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ def _get_core_test_types_to_run(self) -> list[str]:
def _get_providers_test_types_to_run(self, split_to_individual_providers: bool = False) -> list[str]:
if self._default_branch != "main":
return []
if self.full_tests_needed:
if self.full_tests_needed or self.run_task_sdk_tests:
if split_to_individual_providers:
return list(providers_test_type())
else:
Expand Down
12 changes: 6 additions & 6 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,16 +516,16 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
",mypy-airflow,mypy-dev,mypy-docs,mypy-providers,mypy-task-sdk"
",ts-compile-format-lint-ui,ts-compile-format-lint-www"
),
"skip-providers-tests": "true",
"skip-providers-tests": "false",
"upgrade-to-newer-dependencies": "false",
"core-test-types-list-as-string": (
"API Always CLI Core Operators Other Serialization WWW"
),
"providers-test-types-list-as-string": "",
"providers-test-types-list-as-string": "Providers[-amazon,google,standard] Providers[amazon] Providers[google] Providers[standard]",
"needs-mypy": "true",
"mypy-checks": "['mypy-task-sdk']",
"mypy-checks": "['mypy-providers', 'mypy-task-sdk']",
},
id="Task SDK source file changed - Task SDK & Core tests should run",
id="Task SDK source file changed - Task SDK, Core and provider tests should run",
)
),
(
Expand Down Expand Up @@ -2474,11 +2474,11 @@ def test_provider_compatibility_checks(labels: tuple[str, ...], expected_outputs
("task_sdk/src/airflow/sdk/a_file.py",),
{
"needs-mypy": "true",
"mypy-checks": "['mypy-task-sdk']",
"mypy-checks": "['mypy-providers', 'mypy-task-sdk']",
},
"main",
(),
id="Airflow mypy checks on Task SDK files",
id="Airflow mypy checks on Task SDK files (implies providers)",
),
pytest.param(
("docs/a_file.py",),
Expand Down
Loading