AIP-38 Invalidate DryRun query cache on submit #46238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ephraimbuddy,
jscheffl and
ryanahamilton
as code owners
pierrejeambrun
force-pushed
the
invalidate-dry-run-query-cache-on-submit
branch
from
c3621cd to
6fc1eb9
Compare
bbovenzi
approved these changes
Jan 29, 2025
Contributor
|
lgtm but looks like some db tests are unhappy |
Member
Author
Yes main is broken for some other reason. I'll wait for #46245 that should fix them. |
shubhamraj-git
approved these changes
Jan 29, 2025
Contributor
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
+1 LGTM post main gets fixed.
bbovenzi
force-pushed
the
invalidate-dry-run-query-cache-on-submit
branch
from
6fc1eb9 to
0ec70e1
Compare
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 30, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a
clearor amarks asaction, we should invalidate the associated DryRun query. Otherwise the modal displaying the affected task instance table will keep showing old responses after a successful submit.To reproduce the issue, you can clear a task instance and then